generated from cpp-best-practices/cmake_template
-
Notifications
You must be signed in to change notification settings - Fork 2
Cleanups add missing features #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lefticus
wants to merge
39
commits into
develop
Choose a base branch
from
cleanups_add_missing_features
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* via Claude
* coverage reporting target also added
* this will never be supported * gets us to 98.8% code coverage
* ' are translated into (quote ) blocks * literals are quoted when desired
* add many more tests * fix scoping of closures * register name with closure
- Update fuzz_tester to actually test cons_expr parser and evaluator - Add cons_expr target to fuzz_test CMakeLists.txt - Fix braces issue in make_quote function to fix compiler warnings - Update gitignore for Claude settings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add --file option to cons_expr_cli to execute scripts from files - Use filesystem library for file handling - Add test_script.scm file for testing - Add CLI tests for file input handling 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added check in process_string_escapes to detect and handle strings that end with an unescaped backslash, properly returning an error instead of silently creating a potentially invalid string. Also added test cases for string escape sequences, conditions, error handling, recursion with closures, and list construction, along with updated CMakeLists.txt to include the new test files. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add comprehensive instructions for running branch coverage reports using the pre-configured build-coverage directory and gcovr tool. Includes specific commands, required flags, and notes about handling dependency errors. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add SmallVector overflow scenarios in constexpr_tests.cpp - Add missing number parsing edge cases in parser_tests.cpp - Add string escape error conditions in string_escape_tests.cpp - Focus on untested branches without duplicating existing functionality - Increase branch coverage from 36% to 35% (745/2095 branches) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…se tests - Add 6 new test categories targeting uncovered branches in cons_expr library - Cover Scratch class move semantics, closure self-reference, and list bounds checking - Test complex parsing edge cases, malformed expressions, and function invocation errors - Validate advanced error handling, nested error propagation, and type mismatches - Increase total test count from 297 to 309 tests with all tests passing - Improve validation of parser robustness, memory management, and type safety 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…o 36% Added 6 new test cases with multiple sub-tests each targeting previously uncovered code paths: - Number parsing edge cases and arithmetic operations - Conditional expression and control flow coverage - Template specialization and type handling coverage - Advanced list operations and memory management - Parser token handling and quote processing - SmallVector overflow and mathematical operations All 320 tests pass in both constexpr and runtime modes, ensuring correctness at compile-time and runtime. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…red branches Added 4 comprehensive test cases with systematic targeting of specific uncovered code paths: - Error path coverage targeting lines 263 (number parsing failures) and 860-868 (function invocation errors) - Parser edge cases and malformed input coverage (unterminated strings, unmatched parentheses, comment handling) - Type conversion and mathematical edge cases (type mismatch errors, floating point precision) - Advanced control flow and scope edge cases (nested scopes, lambda parameter validation, complex cond expressions) Increased branch coverage from 742 to 758 taken branches (+16 branches). All 329 tests pass in both constexpr and runtime modes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Previously, car returned an error for empty lists while cdr returned an empty list. This inconsistency has been fixed to follow Scheme standards where both operations are errors on empty lists. - Update cdr to return error "cdr: cannot take cdr of empty list" - Add comprehensive tests for car/cdr error handling - Update existing tests that expected the old cdr behavior - Add documentation comments noting the error behavior This is a breaking change for code that relied on (cdr '()) returning '(). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.