Skip to content

Conversation

@tnull
Copy link
Collaborator

@tnull tnull commented Nov 19, 2025

Unfortunately, doc_auto_cfg was removed, breaking doc builds for v0.7.0-rc.0. Here we replace it with the doc_cfg attribute.

Unfortunately, `doc_auto_cfg` was removed, breaking doc builds for
v0.7.0-rc.0. Here we replace it with the `doc_cfg` attribute.
@tnull tnull requested a review from tankyleo November 19, 2025 20:57
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Nov 19, 2025

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull added this to the 0.7 milestone Nov 19, 2025
Copy link

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked up docs.rs docs, thought you might want to add this to CI somewhere instead of the script we've got in LDK:
https://docs.rs/about/builds#testing-builds-ci
https://github.com/dtolnay/cargo-docs-rs

@tnull tnull merged commit 3a767bc into lightningdevkit:release/0.7 Nov 19, 2025
17 checks passed
@tnull
Copy link
Collaborator Author

tnull commented Nov 19, 2025

Looked up docs.rs docs, thought you might want to add this to CI somewhere instead of the script we've got in LDK: https://docs.rs/about/builds#testing-builds-ci https://github.com/dtolnay/cargo-docs-rs

Yeah, maybe that would be worth. For now going ahead landing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants