-
Notifications
You must be signed in to change notification settings - Fork 60
LCORE-754: Add TLS profiles #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
onmete
wants to merge
1
commit into
lightspeed-core:main
Choose a base branch
from
onmete:tls-profiles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # TLS Security Profile Configuration | ||
|
|
||
| This document describes how to configure and test the TLS security profile for outgoing connections to the Llama Stack provider. | ||
|
|
||
| ## Overview | ||
|
|
||
| The TLS security profile allows you to enforce specific TLS security settings for connections from Lightspeed Stack to the Llama Stack server. This includes: | ||
|
|
||
| - **Profile Type**: Predefined security profiles (OldType, IntermediateType, ModernType, Custom) | ||
| - **Minimum TLS Version**: Enforce minimum TLS protocol version (TLS 1.0 - 1.3) | ||
| - **Cipher Suites**: Specify allowed cipher suites | ||
| - **CA Certificate**: Custom CA certificate for server verification | ||
| - **Skip Verification**: Option to skip TLS verification (testing only) | ||
|
|
||
| ## Configuration | ||
|
|
||
| Add the `tls_security_profile` section under `llama_stack` in your configuration file: | ||
|
|
||
| ```yaml | ||
| llama_stack: | ||
| url: https://llama-stack-server:8321 | ||
| use_as_library_client: false | ||
| tls_security_profile: | ||
| type: ModernType | ||
| minTLSVersion: VersionTLS13 | ||
| caCertPath: /path/to/ca-certificate.crt | ||
| ``` | ||
|
|
||
| ### Configuration Options | ||
|
|
||
| | Field | Type | Description | | ||
| |-------|------|-------------| | ||
| | `type` | string | Profile type: `OldType`, `IntermediateType`, `ModernType`, or `Custom` | | ||
| | `minTLSVersion` | string | Minimum TLS version: `VersionTLS10`, `VersionTLS11`, `VersionTLS12`, `VersionTLS13` | | ||
| | `ciphers` | list[string] | List of allowed cipher suites (optional, uses profile defaults) | | ||
| | `caCertPath` | string | Path to CA certificate file for server verification | | ||
| | `skipTLSVerification` | boolean | Skip TLS certificate verification (default: false, **testing only**) | | ||
|
|
||
| ### Profile Types | ||
|
|
||
| | Profile | Min TLS Version | Description | | ||
| |---------|-----------------|-------------| | ||
| | `OldType` | TLS 1.0 | Legacy compatibility, wide cipher support | | ||
| | `IntermediateType` | TLS 1.2 | Balanced security and compatibility | | ||
| | `ModernType` | TLS 1.3 | Maximum security, TLS 1.3 only | | ||
| | `Custom` | Configurable | User-defined settings | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / Bandit
Call to httpx with verify=False disabling SSL certificate checks, security issue. Error