Added OptionFormatter TextBox Formatter #2193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xStrom
reviewed
Jan 12, 2023
Member
xStrom
left a comment
xStrom
left a comment
There was a problem hiding this comment.
Really sorry for letting this wait so long.
Please rebase on master so we can pass the CI without clippy errors. After we pass the CI I will take a deeper look.
|
|
||
| ### Added | ||
|
|
||
| - OptionFormatter TextBox Formatter ([#2193] by [@meettitan]) |
Member
There was a problem hiding this comment.
Unfortunately the links don't get automatically generated. Please define both [#2193] and [@meettitan] at the bottom of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple TextBox Formatter for optional values. inspired by ParseFormatter. Useful for integers to map empty strings to Option::None.