Remove warnings from Rust 1.89.0 #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenzV
reviewed
Aug 15, 2025
| pub use f32x8_t::f32x8; | ||
| pub use i32x4_t::i32x4; | ||
| pub use i32x8_t::i32x8; | ||
| #[allow(unused_imports)] |
Contributor
There was a problem hiding this comment.
Why is this one unused if it's a public export?
Contributor
Author
There was a problem hiding this comment.
wide module is private to the crate.
Contributor
Author
There was a problem hiding this comment.
This warning was probably here before 1.89.0 though
Contributor
|
Also, please rebase to main so that the CI issues are fixed. |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.89.0 (release Aug. 7th) introduces many warnings related to elided lifetimes.
This PR amends the code to satisfy the compiler.