Skip to content

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Dec 30, 2025

Description 📝

Small fix to increase the amount of entities (chips) rendered for a given role in the Assigned Roles table.

The reason for the needed fix is that Volume labels can be 1 CHAR long, and limiting at the previous 15 value would prevent rendering all volume entities chips. It is an edge case, but a bug nonetheless.

Changes 🔄

  • Increase AssignedEntities MAX_ITEMS_TO_RENDER to 25

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
localhost_3000_iam_users_abailly-iam-restricted_roles localhost_3000_iam_users_abailly-iam-restricted_roles (1)

How to test 🧪

Prerequisites

An IAM enabled account

Reproduction steps

  • Create 16+ Volumes labeled from a to s (for instance)
  • Navigate to /iam/users//roles and assign the Volume Contributor role with all volumes with 1 letter label
  • 🚫 only 15 entities will show

Verification steps

  • Create 16+ Volumes labeled from a to s (for instance)
  • Navigate to /iam/users//roles and assign the Volume Contributor role with all volumes with 1 letter label
  • ✅ Confirm all 15 entities show and get truncated properly
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing869 Passing11 Skipped44m 49s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

2 participants