iobuffer: Fix encoding/decoding on big-endian #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible (albeit unusual) to boot a big-endian system on a smartphone, and it's generally good to have portable code. Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
Collaborator
flamingradian
left a comment
flamingradian
left a comment
There was a problem hiding this comment.
Sorry for not sending a review earlier. I wanted to not add extra functions but couldn't think of how to do this until now.
Comment on lines
+58
to
61
| ctx->size &= ~(mask_bytes(segment) << ctx->size_off * 8); | ||
| ctx->size |= read_le(buf, segment) << ctx->size_off * 8; | ||
| ctx->size_off = (ctx->size_off + segment) % 4; | ||
| ctx->align = (ctx->align + segment) & 0x7; |
Collaborator
There was a problem hiding this comment.
Suggested change
| ctx->size &= ~(mask_bytes(segment) << ctx->size_off * 8); | |
| ctx->size |= read_le(buf, segment) << ctx->size_off * 8; | |
| ctx->size_off = (ctx->size_off + segment) % 4; | |
| ctx->align = (ctx->align + segment) & 0x7; | |
| memcpy(&((char *) &ctx->size)[ctx->size_off], buf, segment); | |
| ctx->size_off = (ctx->size_off + segment) % 4; | |
| ctx->align = (ctx->align + segment) & 0x7; | |
| if (ctx->size_off == 0) | |
| ctx->size = htole32(ctx->size); |
Maybe this could be converted to host endianness after completely reading the size, instead of adding small functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible (albeit unusual) to boot a big-endian system on a smartphone, and it's generally good to have portable code.
The code readability is debatable, but the function is tested on little-endian and big-endian systems. The iobuffer test passes.