Skip to content

Conversation

@Jakuje
Copy link
Collaborator

@Jakuje Jakuje commented Jan 1, 2026

Enhancement: Add new configuration option VersionAddendum

Reason: The OpenSSH introduced a new configuration option.

Result: The users can use the new configuration option when configuring SSH.

Issue Tracker Tickets (Jira or BZ if any): -

Summary by Sourcery

New Features:

  • Expose the VersionAddendum SSH option in match blocks, host blocks, and global SSH client configuration rendering.

Signed-off-by: Jakub Jelen <jakuje@gmail.com>
@Jakuje Jakuje requested a review from richm as a code owner January 1, 2026 22:24
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 1, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds support for the new OpenSSH VersionAddendum configuration option across SSH Jinja templates so it can be rendered in Match, Host, and global sections, and wired into the dev tooling option definitions.

Flow diagram for VersionAddendum through SSH Jinja templates

flowchart TD
  Vars[VersionAddendum defined in inventory or variables]
  DevTools[Dev tools options_body entry for VersionAddendum]
  TemplateMatch[render_option VersionAddendum in Match blocks]
  TemplateHost[render_option VersionAddendum in Host blocks]
  TemplateGlobal[body_option VersionAddendum in global section]
  Render[Ansible or templating engine renders ssh_config.j2]
  SSHConfig[Generated ssh_config with VersionAddendum directives]

  Vars --> DevTools
  Vars --> Render
  DevTools --> Render
  Render --> TemplateMatch
  Render --> TemplateHost
  Render --> TemplateGlobal
  TemplateMatch --> SSHConfig
  TemplateHost --> SSHConfig
  TemplateGlobal --> SSHConfig
Loading

File-Level Changes

Change Details Files
Add VersionAddendum support to Match blocks in the SSH config template.
  • Render VersionAddendum for each Match entry using the existing render_option helper with the per-match VersionAddendum value.
  • Ensure VersionAddendum participates in the same conditional rendering logic as other Match-level options.
templates/ssh_config.j2
Add VersionAddendum support to Host blocks and global body options in the SSH config template.
  • Render VersionAddendum for each Host entry using render_option with the per-host VersionAddendum value.
  • Include VersionAddendum in the body_option list for top-level/global SSH configuration, wired to ssh_VersionAddendum.
  • Keep ordering consistent by placing VersionAddendum near other identification-related options like VerifyHostKeyDNS and VisualHostKey.
templates/ssh_config.j2
Wire VersionAddendum into dev tooling option metadata.
  • Extend the dev-tools options_body definition to include VersionAddendum so generator/validation tooling is aware of the new option.
  • Align naming and structure with existing SSH options to avoid breaking the dev tooling pipeline.
.dev-tools/options_body

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm changed the title feat: Add new configuration optoin VersionAddendum feat: Add new configuration option VersionAddendum Jan 2, 2026
@richm
Copy link
Contributor

richm commented Jan 2, 2026

[citest]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants