Skip to content

Conversation

@hillwoodroc
Copy link
Contributor

deepin-pdfium has been continuously maintained and updated, so there is no need to bundle an older version inside the project.

deepin-pdfium 一直都在正常维护更新,为什么要内置一个更旧的版本而不是在项目里面链接 deepin-pdfium ?

Log: This fix replaces the built-in deepin-pdfium with the system-provided PkgConfig-based deepin-pdfium package.

@deepin-ci-robot
Copy link

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hillwoodroc

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-pdfium has been continuously maintained and updated, so there is no
need to bundle an older version inside the project.

Log: This fix replaces the built-in deepin-pdfium with the system-provided
PkgConfig-based deepin-pdfium package.
@lzwind
Copy link
Contributor

lzwind commented Dec 12, 2025

因为兼容性的原因,不能合入。我们在最新版本需要同时支持Qt5与Qt6同时构建包。

@hillwoodroc
Copy link
Contributor Author

为什么不在旧环境里面打包一个旧版本的 deepin-pdfium ?用内置死代码对新环境非常不友好。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants