extension.js: Put back "notifications" role removed in commit ... #13303
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... linuxmint@1c995f6 While the "notifications" role is no longer used in cinnamon 6.6, removing the role in cinnamon prevents 3rd party applets from loading if the role is listed in the 3rd party's metadata.json file. While the 3rd party applet can be versioned to adapt to the changes in cinnamon, the metadata.json file cannot. Therefore the applet should not be prevented from loading even though "notifications" role is no longer used in cinnamon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... 1c995f6
While the "notifications" role is no longer used in cinnamon 6.6, removing the named role in
extension.jsprevents 3rd party applets from loading if the role is listed in the 3rd party's metadata.json file. While the 3rd party applet can be versioned to adapt to the changes in cinnamon 6.6, the metadata.json file cannot. Therefore the applet should not be prevented from loading even though the "notifications" role is no longer used in cinnamon.Fixes linuxmint/cinnamon-spices-applets#8114