Warn from system tray when reboot is required #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This works, but it currently only shows if the system ends up being completely up-to-date. I think it should show any time the reboot banner is showing, which would include more updates being available. Maybe something like: |
Based on `mintupdate-error-symbolic.svg` GTK SVG color use reference: https://docs.gtk.org/gtk4/icon-format.html#supported-svg-attributes
Prioritize the 'reboot required' icon over 'available updates' according to mtwebster's feedback and continue informing if there are selected updates. Also align with the opening delimiter, based on PEP8 style guide. Reference: https://peps.python.org/pep-0008/#indentation Co-authored-by: Michael Webster <miketwebster@gmail.com>
randomnoise
force-pushed
the
reboot-trayicon
branch
from
f5c4cca to
dc893ea
Compare
Contributor
Author
Thanks for the feedback 👍 I prioritized the "Reboot required" icon over "Available updates". Also, I moved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If automated updates are enabled, one may miss for a time that there is a need for a system reboot.
This change warns from the system tray that a system reboot is required.
Hierarchy of icon choice for informing from the system tray
Currently:
(edited) The order with this change:
Screenshot of the change: (panel and tray icon are exaggerated for convenience)
GTK SVG color use reference: