Skip to content

Block ev_sidebar_tree_selection_changed handler during sidebar destroy #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaeheonshim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Block ev_sidebar_tree_selection_changed handler during sidebar destroy #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions shell/ev-sidebar-thumbnails.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,9 +1217,23 @@ static void
ev_sidebar_thumbnails_clear_model (EvSidebarThumbnails *sidebar_thumbnails)
{
EvSidebarThumbnailsPrivate *priv = sidebar_thumbnails->priv;
GtkTreeSelection *selection = NULL;

/* Block ev_sidebar_tree_selection_changed handler while clearing the model.
* gtk_list_store_clear() causes the GtkTreeSelection to emit "changed",
* which incorrectly updates the document page when the sidebar is destroyed.
*/
if (priv->tree_view && GTK_IS_TREE_VIEW (priv->tree_view)) {
selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (priv->tree_view));
g_signal_handlers_block_by_func (selection, ev_sidebar_tree_selection_changed, sidebar_thumbnails);
}

gtk_tree_model_foreach (GTK_TREE_MODEL (priv->list_store), ev_sidebar_thumbnails_clear_job, sidebar_thumbnails);
gtk_list_store_clear (priv->list_store);

if (selection) {
g_signal_handlers_unblock_by_func (selection, ev_sidebar_tree_selection_changed, sidebar_thumbnails);
}
}

static gboolean
Expand Down