Included all of my changes. #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueEx Although values set using RegSetValueEx without inclusion of the terminating null in the "cbData" parameter seem to still get null terminated by the system (based upon inspection of the binary data in Registry Editor), the MSDN page for RegSetValueEx is quite clear that the terminating null should be included in "cbData". Indeed, it is already included in one place in EnvVar.cpp. This change ensures that all calls to RegSetValueEx include the terminating null in "cbData". h/t Debra Do
Ensure terminating null is included when setting values via RegSetVal…
Author
|
@liorda you able to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a few other changes like moving the VS2008 projects and solutions to another folder and manually editing them on my iPhone. Note: I cannot configure the projects for VS2008 to match the configs and build target names on the VS2010 express ones. This means someone with VS2008 and VS2010 installed has to set them with the almost exact same settings if possible. I do plan to add an DebugStatic target as well sometime. I also did not touch the envtest project on telling it to link to the static builds on ReleaseStatic on both x86 and x64 targets. However it should be possible to do.
This would also mean doing something similar on DebugStatic. I will set up DebugStatic later when I am on my laptop.