mongoose@4.9.2 breaks build 🚨 #333
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
mongoose just published its new version 4.9.2.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As mongoose is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 1004 commits .
fcff38echore: release 4.9.28042fb4Merge pull request #5076 from bertolo1988/master1edc6abMerge branch 'master' of github.com:Automattic/mongoose2dd76abfix(connection): throw error if username:password includes @ or :6752313Merge pull request #5093 from Jiang-Xuan/patch-170c6fd9fix(discriminator): handle class names consistentlyaae7c57fix(document): ensure subdoc post save runs after parent save2bbc59etest(document): repro #508564b4eb1fix(querycursor): run pre find hooks with .cursor()dc79ff6test(querycursor): repro #5096bbf6166refactor: move more tests into before hooksa160e4erefactor: move more schemas into before hooksb72eacarefactor: move most test schemas into before hooks51b8e80fix(schema): make clone() work with reusing discriminator schemas432360etest(discriminator): repro #5098There are 250 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.