Skip to content

Conversation

@jdeniau
Copy link
Contributor

@jdeniau jdeniau commented Oct 7, 2020

Actually, the $dbName is computed either from $params['dbname'] on $params['master']['dbname'] and override only the dbname parameter (not the master one) and there is no slave management except for sqlite.

This PR compute the dbname from the mysql connection and replace both dbname, master's dbname and all slaves dbname.

I test if the driver is pdo_mysql, but it might be the default case, what do you think ?

@DonCallisto DonCallisto force-pushed the master branch 2 times, most recently from 5ff0587 to f844c76 Compare October 7, 2020 10:16
@DonCallisto
Copy link
Collaborator

I didn't had the chance to take a look at this. Would you mind to rebase this?
Moreoever I can't guarantee I'll have much free time to review this, but sooner or later I'll do.
Thanks.

@jdeniau
Copy link
Contributor Author

jdeniau commented Oct 9, 2020

@DonCallisto rebase done.

Take the time you need for the review, I'm using my patched version for the moment.

Thanks for maintaining this library !

@DonCallisto
Copy link
Collaborator

Doing my best with my little free time.
Thank you for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants