feat(metrics): add generation_tokens_total and prompt_tokens_total metrics #268
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trics Signed-off-by: CYJiang <googs1025@gmail.com>
Contributor
Author
mayabar
requested changes
Dec 7, 2025
| var promptTotal int64 | ||
| s.initFakeHistogram(s.metrics.requestPromptTokens, buckets, s.config.FakeMetrics.RequestPromptTokens) | ||
| for _, v := range s.config.FakeMetrics.RequestPromptTokens { | ||
| promptTotal += int64(v) |
Collaborator
There was a problem hiding this comment.
Values in the FakeMetrics.RequestPromptTokens means number of requests for each bucket. Summarizing all values in the array gives number of requests and not number of tokens.
Same for RequestGenerationTokens.
I would add an additional field for total number of tokens and support 2 cases:
- if user defined the total number of tokens - use it
- if total number of tokens is not defined - use middle value of each bucket * number of requests in this bucket for total number of tokens calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.