[libcxx][docs] Note how to use just built libc++ with per-target runtimes layout #172316
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imes layout Fixes llvm#172024 This is something a lot of people can probably figure out themselves but having this obvious wrong turn in the getting started document isn't a good first impression. So I've adding a note to highlight how to deal with it. I don't want to go into detail there about the layout itself, it should be enough that people know to check by listing the contents of the lib/ folder.
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: David Spickett (DavidSpickett) ChangesFixes #172024 This is something a lot of people can probably figure out themselves but having this obvious wrong turn in the getting started document isn't a good first impression. So I've added a note to highlight how to deal with it. I don't want to go into detail there about the layout itself, but it should be enough that people know to check by listing the contents of the lib/ folder. Full diff: https://github.com/llvm/llvm-project/pull/172316.diff 1 Files Affected:
diff --git a/libcxx/docs/VendorDocumentation.rst b/libcxx/docs/VendorDocumentation.rst
index 3e4b305707258..fc788178c96e4 100644
--- a/libcxx/docs/VendorDocumentation.rst
+++ b/libcxx/docs/VendorDocumentation.rst
@@ -68,6 +68,11 @@ to override it with custom paths. With Clang, this can be done with:
The option ``-Wl,-rpath,<install>/lib`` adds a runtime library search path, which causes the system's
dynamic linker to look for libc++ in ``<install>/lib`` whenever the program is loaded.
+.. note::
+ If the runtimes were built using the "per-target runtime directory" layout,
+ they will be in ``<install>/lib/<target-triple>`` instead of ``<install>/lib``.
+ In this case, use the former path for all library paths in the command above
+ (the path to include files does not change).
The Bootstrapping build
=======================
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172024
This is something a lot of people can probably figure out themselves but having this obvious wrong turn in the getting started document isn't a good first impression.
So I've added a note to highlight how to deal with it.
I don't want to go into detail there about the layout itself, but it should be enough that people know to check by listing the contents of the lib/ folder.