FIX: generate LNURL server-side for unique voucher links #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lud17 support commit (10a4caf) broke unique voucher withdraw links by constructing the LNURL URL client-side using only the unique_hash. For unique vouchers (is_unique=True), the URL must include both unique_hash AND id_unique_hash in the path. The create_lnurl() helper already handles this correctly, but the display page and QR code dialog were bypassing it. Changes: - views.py: Generate LNURL server-side for display page - views_api.py: Add lnurl_url field to API responses - models.py: Add lnurl_url field to WithdrawLink model - index.js: Use lnurl_url from API instead of client-side construction - display.html: Use server-provided URL 🤖 Generated with [Claude Code](https://claude.ai/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PatMulligan
force-pushed
the
fix/unique-voucher-lnurl-display
branch
from
847baf2 to
ac5f06b
Compare
dni
approved these changes
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #64
Problem
Commit 10a4caf (feat: add lud17 support) introduced a regression where both the display page and the index page QR code dialog construct LNURL URLs client-side using only the unique_hash.
For unique voucher links (is_unique=True), the URL must include both unique_hash AND id_unique_hash in the path:
This caused unique voucher links (created via "Quick vouchers" or with the unique checkbox enabled) to return:
{"status":"ERROR","reason":"This link requires an id_unique_hash."}Solution
The create_lnurl() helper already handled unique links correctly - the fix ensures all UI code paths use it.
Test plan
🤖 Generated with https://claude.ai/claude-code