-
Notifications
You must be signed in to change notification settings - Fork 3
[feat] add "invite a friend" #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
islandbitcoin
wants to merge
1
commit into
main
Choose a base branch
from
feat/invite-friend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brh28
reviewed
Sep 11, 2025
Contributor
brh28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only about 10% through so far
Contributor
Author
|
putting this back to draft mode to make changes based on feedback, and wait for twilio to approve messaging so I can test end-to-end |
55546c9 to
b9efa8d
Compare
ae55ba0 to
60d9d24
Compare
Contributor
Author
|
much cleaner PR, ready for another review |
8faac76 to
f4685cf
Compare
Contributor
Author
|
@brh28 please review |
Add comprehensive invite-friend feature allowing users to invite friends via Email, SMS, or WhatsApp. **User-Facing Features:** - Create invites: Users can send invites via Email (SendGrid), SMS, or WhatsApp (Twilio) - Redeem invites: New users can redeem invites within 1 hour of account creation - Preview invites: Unauthenticated endpoint to preview invite before registration - Rate limiting: 10 invites/day per user, 3 invites/day per target contact (Redis-based) - 24-hour invite expiration with Firebase Dynamic Links support **Admin Features:** - View invite details with inviter/redeemer information - List and filter invites by status and inviter - Paginated invite queries **Technical Implementation:** - MongoDB schema for invite tracking with secure token hashing (SHA-256) - Notification service supporting Email, SMS, and WhatsApp - Contact validation for email/phone formats - Deep linking support via Firebase Dynamic Links - Comprehensive test coverage (unit & integration tests) **Security:** - Tokens are 40-character random strings with only SHA-256 hash stored - Contact verification ensures invite sent to correct recipient - Account age validation (< 1 hour) for new user redemption - Self-redemption prevention
f4685cf to
55b827d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.