-
Notifications
You must be signed in to change notification settings - Fork 182
Fix wtr-lab #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix wtr-lab #1942
Conversation
|
Uncertain if I want to put in the work for the other searches- and uncertain if I'll succeed if I do. Marked them as TODOs. Edit: Ugh. Even after fixing the two bugs below, web translation works in dev but not on the app. |
|
@CD-Z @rajarsheechatterjee @nyagami Problem: Solution: Honestly I don't have any idea how to add a library to the main app correctly, and that seems like a notable change, so I'd like some feedback. The code works in dev with this library added in the latest commit. |
Co-authored-by: oussama <mrissaoussama@gmail.com>
Fixes #1689
Fixes #1535
Fixes #1498
Fixes #1495
Issues:
Broken novel parsing
Broken ToC parsing - Separate json request instead of in source used now
Broken chapter parsing
Searches repeating
Web translation wasn't available
Solutions:
Fixed novel parsing
Added ToC json request
Use new chapter API
Switched to better searches
Fallback to web translation
Known Problems/TODO:
Web translation works in dev but not on app? (Missing library)