Skip to content

Conversation

@Rojikku
Copy link
Contributor

@Rojikku Rojikku commented Dec 23, 2025

Fixes #1689
Fixes #1535
Fixes #1498
Fixes #1495

Issues:
Broken novel parsing
Broken ToC parsing - Separate json request instead of in source used now
Broken chapter parsing
Searches repeating
Web translation wasn't available

Solutions:
Fixed novel parsing
Added ToC json request
Use new chapter API
Switched to better searches
Fallback to web translation

Known Problems/TODO:
Web translation works in dev but not on app? (Missing library)

@Rojikku Rojikku marked this pull request as ready for review December 25, 2025 01:49
@Rojikku
Copy link
Contributor Author

Rojikku commented Dec 25, 2025

Uncertain if I want to put in the work for the other searches- and uncertain if I'll succeed if I do. Marked them as TODOs.
Current state functions and is an improvement, so is valid to be merged.
If review takes a while I might add more. If not I'll do another PR and finish it all in that, if I do it.

Edit: Ugh. Even after fixing the two bugs below, web translation works in dev but not on the app.
Edit2: Oh...Property 'crypto' doesn't exist...cool...

@Rojikku Rojikku marked this pull request as draft December 25, 2025 02:26
@Rojikku
Copy link
Contributor Author

Rojikku commented Dec 26, 2025

@CD-Z @rajarsheechatterjee @nyagami
Need to add a library for this plugin to support the web translation feature.

Problem:
AES-GCM encryption
crypto.subtle is present in web browsers, but not the app.

Solution:
AES-GCM decryption
Add noble library?

Honestly I don't have any idea how to add a library to the main app correctly, and that seems like a notable change, so I'd like some feedback.
Is this possible?
Can someone do a PR and have a relevant library added for a 2.0.3 so we can update this plugin? Is it easy?
Is there a better solution I'm missing?

The code works in dev with this library added in the latest commit.
If we can get crypto.subtle, the previous version without the library also worked in dev.
I believe the only thing holding this back from completion is a crypto library.

Co-authored-by: oussama <mrissaoussama@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant