Skip to content

Automate GDS style '(optional)' on titles #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ekes wants to merge 8 commits into from
Closed

Automate GDS style '(optional)' on titles #129

ekes wants to merge 8 commits into from

Conversation

@ekes
Copy link
Member

@ekes ekes commented Dec 11, 2025 •
edited
Loading

Just that. It'll add '(optional)' to the titles of elements on a webform that are not required.

To test use the branch, and then go to /admin/structure/webform/config and check the Third Party setting
image

  • Expected behaviour (optional) added to the titles of elements that aren't required. Will also work with conditionals.
  • Undesirable behaviour to look-out for: there might be elements that need to be excluded from the automated change (at the moment this is single checkboxes and radios, and every element of an address if all elements are optional -- but there might be, probably are, more we want to exclude).

ekes added 8 commits November 28, 2025 14:22
@ekes
Allow Title, Help and Description to be set (overriden). Fixes #122
9e4ab53
@ekes
Initial PoC to show after build callback works for #102
497ea9c
@ekes
WIP: adds js to toggle (optional) on conditional, add opt in config.
dac55f4 
To Do:
 * Add more elements
 * Test those elements with JS
 * Add opt-in default for new installs
 * Test.
@ekes
Initial PoC to show after build callback works for #102
74bf654
@ekes
WIP: adds js to toggle (optional) on conditional, add opt in config.
ca7f340 
To Do:
 * Add more elements
 * Test those elements with JS
 * Add opt-in default for new installs
 * Test.
@ekes
Set up logic for when to add (optional), or rather when not.
f0f1222
@ekes
Merge branch 'feature/102-optional' of https://github.com/localgovdru…
2106bd3 
…pal/localgov_forms into feature/102-optional
@ekes
OOps! Tidy that merge conflict properly.
374b446
@ekes
Copy link
Member Author

ekes commented Dec 11, 2025

Ah I should push this to drupal.org meh.

@ekes
Copy link
Member Author

ekes commented Dec 11, 2025

git.drupal.org version of this MR https://git.drupalcode.org/project/localgov_forms/-/merge_requests/3

@ekes
Copy link
Member Author

ekes commented Dec 11, 2025

Closing this in preference to the drupal.org one because well there's the up to date code.

@ekes ekes closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lazysoundsystem lazysoundsystem Awaiting requested review from lazysoundsystem

@siliconmeadow siliconmeadow Awaiting requested review from siliconmeadow

@msayoung msayoung Awaiting requested review from msayoung

@PardeepSinghBali PardeepSinghBali Awaiting requested review from PardeepSinghBali

@sgroi-l sgroi-l Awaiting requested review from sgroi-l

@zuhayr-walsall zuhayr-walsall Awaiting requested review from zuhayr-walsall

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ekes