Skip to content

Initial interactive mode #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Morishiri wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Initial interactive mode #109

Morishiri wants to merge 12 commits into from

Conversation

@Morishiri
Copy link
Contributor

@Morishiri Morishiri commented Mar 2, 2021

No description provided.

@Morishiri Morishiri mentioned this pull request Mar 2, 2021
Closed
@Morishiri Morishiri changed the title Feature interactivity Initial interactive mode Mar 2, 2021
@Morishiri Morishiri added the WIP Work in progress label Mar 2, 2021
@denny241 denny241 force-pushed the feature-interactivity branch 3 times, most recently from 7c70d28 to 7067706 Compare March 29, 2021 10:35
@denny241 denny241 force-pushed the feature-interactivity branch from 7067706 to 7e59087 Compare October 20, 2021 11:22
@denny241 denny241 force-pushed the feature-interactivity branch from 0acfcee to 38cc33a Compare June 24, 2022 10:25
@denny241 denny241 added enhancement New feature or request and removed WIP Work in progress labels Jun 24, 2022
@denny241
Copy link
Contributor

denny241 commented Jun 24, 2022

@Morishiri when you have the time it would be nice if you could let me know if everything looks OK like this; feature-wise I tested most things with the normal CLI, the interactive mode and the GUI and everything worked fine.

(couldn't request a review the normal way because you own this pull request)

@denny241 denny241 force-pushed the feature-interactivity branch from d69c86f to 4aec5ff Compare March 31, 2023 12:32
@denny241
Copy link
Contributor

denny241 commented Mar 31, 2023

Reviewing this again from the viewpoint of our current master branch, I notice that the closehandler is used in several places. On master we don't use that pkg at all anymore, so I'll have to investigate if everything is still compatible or if this branch needs to be converted to a new approach.

@denny241
Copy link
Contributor

denny241 commented Apr 13, 2023

Everything works and I don't see any obvious flaws. I lack the experience for judging whether the way it works could lead to complications down the line, so let me know if this needs to be rewritten for that reason.

@denny241 denny241 linked an issue Apr 13, 2023 that may be closed by this pull request
Add interactive mode #64
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@denny241 denny241

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add interactive mode

3 participants

@Morishiri @denny241