Fixes for Android API 35 #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase targetSdkVersion, fix lordi#163
Fixes lordi#162 Problem is that the EditText of an EditTextPreference is not part of the layout when setting a custom layout. But the EditText is used like it is part of the layout and will return null every for various calls that will lead to a crash. By adding the EditText to the custom layout, it works. But it's still just a hack.
flyingOwl
force-pushed
the
flyingOwl/android_api_35
branch
from
82b6780 to
9d21c4a
Compare
Owner
|
Hi, thanks for the PR! For merging I think the unit tests would need to run which are currently failing. Would it be possible for you to check these? Do you use Tickmate via Play store or F-Droid? |
Contributor
Author
|
I tried to run Tickmate from F-Droid but I experienced the same crashes when changing the icon or the color of a track as others. I will check the unit tests! |
Contributor
Author
|
The unit tests were failing due to outdated dependencies. That should be fixed now. |
Owner
|
Thanks. If I find the time I'll look into releasing a new version this weekend |
This was referenced Jan 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase target SDK to 35 so it will run on current versions of Android.
One commit fixes the crash when changing the color and icon of a track (see #162 and #157). Another commit adds working notifications for Android 13+ which needs a requestPermissions() call.
Note: This is just a quick fix to put the app in a working state again. A lot of stuff in the code is deprecated and needs a proper refactoring.