Skip to content

Conversation

@jhlegarreta
Copy link
Contributor

Add the GPURenderDemo.cxx example from the VTK source tree to the VTK wiki
examples repository along with the necessary input data.

Add the GPURenderDemo.cxx example from the VTK source tree to the VTK wiki
examples repository along with the necessary input data.
@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Apr 27, 2017

@acbauer This example does not really fit into the simplicity criterion, but I think it is interesting and demonstrates a whole lot of concepts and possibilities. If not, we can reject the PR.

Now, I'm also aware that when using the a GPU version of whatever class it is usually interesting to know its advantages or performance compared to the common version. Should we address this?

@lorensen I was unable to run the example with other input data, such as DICOM or MHA files. Even within the VTK source tree I got a black render window. The same happened to the FixedPointVolumeRayCastMapperCT example (and in this case, it even did not work with the hncma-atlas.vti file), so I asked the folks to have a look at this last example at least.

@acbauer
Copy link

acbauer commented Apr 27, 2017

I'm a bit uncomfortable with copying something from VTK examples to this repo since they could easily get out of sync. I'd think that maybe a better way would be to just somehow link to the example in VTK from the wiki page.

Also, it's a bad idea to remove the VTK copyright section from the original file, especially when you're pushing to one of the copyright holder's github repos :) I wouldn't think that Bill, Ken or Will would strenuously object to that though but better to avoid that issue from the start in my opinion.

That does bring up a good point though -- these examples should probably have some type of license associated with them. This provides other developers a known way of using these example. Maybe they already do though and I just missed it.

@jhlegarreta
Copy link
Contributor Author

Concerning the copyright notice, I do agree that completely removing it is not probably a good idea; I just noticed that those examples that I looked at did not have it, and simply removed it, but I should have asked. Sorry.

@acbauer
Copy link

acbauer commented Apr 27, 2017

No big deal to me about the copyright notice and I'd bet that Bill, Will and Ken wouldn't care about it either, especially since it's in VTK-related stuff. I think the more important thing is that there is some type of copyright/license with these examples so that others know exactly how and how NOT to use them. You'd probably be surprised at how often parts of these examples are copy-and-pasted into other codes (as I think they should be). Since the BSD-style VTK license is meant to be highly non-intrusive it makes it easy for others to know that they can use it safely without fear of lawsuits, etc.

Also, Github has been strongly encouraging projects to include some copyright

@lorensen
Copy link
Owner

lorensen commented Apr 27, 2017 via email

@lorensen
Copy link
Owner

lorensen commented Apr 27, 2017 via email

@lorensen
Copy link
Owner

lorensen commented Apr 27, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants