Improvements to adc_ctrl_filters_polled_vseq #28998
Open
+175
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a bit complicated: all it's really doing is to ask a couple of existing sequences to set some variables in a series. This patch simplifes things dramatically. For a start, it runs one vseq per channel, which means the new adc_ctrl_channel_ramp_vseq can be a bit simpler than adc_ctrl_random_ramp_vseq was. It also avoids messing around with the "rising" flag: we can just use a start and end value and have the direction implicit. Indeed, it could have been even shorter(!), but I decided it was wiser not to rely on unsigned wrapping in adc_ctrl_channel_ramp_vseq::body. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
This function is essentially counting slowly from 0 to 1024 and it was previously doing so in randomised steps between 0 and 4. This takes a long time! And it's not very likely that we really care about some particular number on the way. Speed things up by a factor of 10 or so. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
requested review from
alees24 and
hcallahan-lowrisc
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was triggered by me trying to understand a test failure, but I realised that this sequence could be both simpler to understand and could run dramatically faster. These two commits are doing that.