Backport 26608 ([manuf,signing] enable SKU configs to share signature dirs) #29003
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for signing binaries with sphincs+ keys. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit a151dee)
This updates the perso FW offline signing rule to enable different SKU configs to share signature Bazel target locations. Signed-off-by: Tim Trippel <ttrippel@google.com> (cherry picked from commit 73a5504)
jwnrt
approved these changes
Jan 5, 2026
Contributor
jwnrt
left a comment
jwnrt
left a comment
There was a problem hiding this comment.
Is the problem that before there would be duplicates in this list, but using a depset and then converting to a list deduplicates them?
Contributor
Author
I believe this is the intent but this duplication probably only occurs with the closed-source SKUs. Hopefully @timothytrippel can shed some light on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26608. Depends on #29002