Backport 26640 ([hsmtool] Generalize handling of sensitive attributes in attrs.rs.) #29015
+46
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
jwnrt,
moidx and
timothytrippel
and removed request for
a team
Besides `CKA_VALUE` There are aother attributes that may be sensitive and should not be accessed if `CKA_SENSITIVE` is set to true. This change adds the `AttributeMap::sensitive_attrs` static function to get a manually compiled list of sensitive attributes. The `AttributeMap:from_object` method was refactored to properly handle potentially sensitive fields. Signed-off-by: Miguel Osorio <miguelosorio@google.com> (cherry picked from commit 0413bd0)
pamaury
force-pushed
the
backport_26640
branch
from
5795af1 to
51f4ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26640. Had to fix a rustfmt lint.