Backport 26594 ([ownership] Allow use of detached signatures in flash ) #29018
+483
−557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Consolidate public key data into `owner_keydata_t`. 2. Eliminate RSA as a supported algorithm. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit f785f1b)
Refactor the ROM_EXT signature verification functions into a verify function that can be used both for validating application payloads and ownership operations. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit 28a96b5)
This target is a left-over from pre-ownership RSA verification and is no longer needed. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit 81f7aac)
pamaury
requested review from
cfrantz,
jwnrt and
moidx
and removed request for
a team
Allow using detached signatures in flash for owner operations. 1. A detached signature is detected when the 64-byte built-in ECDSA signature field is all zeros. 2. The entire flash DATA region is scanned for a detached signature. The signature must be aligned on a flash page boundary and must contain the command/entity that it is signing and the current ROM_EXT nonce. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit 284716b)
The auxilliary ECDSA wrapper library was added at the start of ownership development because we had not yet created our own implmentation using the OTBN accelerator. Now that owner signature verification is consolidated into `owner_verify`, we no longer need the ECDSA wrapper library. Signed-off-by: Chris Frantz <cfrantz@google.com> (cherry picked from commit 4d44b10)
pamaury
force-pushed
the
backport_26594
branch
from
5ba5923 to
961e5ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26594. Depends on #28992. Only review the last 2 commits.