No atomicwrites

[mathstuf]

---

Fixes: #342.

[lucc]

Looking good so far.

Can you please add a docstring and type hints like in the rest of the code.

If you have the time you could also migrate the pytest tests from the original atomicwrites repo to stdlib unittest framework. But I recognize that this is a bit more work. (Test would be nice though so if you do not have the time I will look into it)

And I added a commit which I would ask you to squash into the "revert" commit because I want to keep some of the nix code changes.

[mathstuf]

I added some docstrings. I don't really know what typehints do with @contextlib.contextmanager, so I'll just use CI to figure that out…

[mathstuf]

I didn't drag the tests over; I don't really have a modern Python dev set up to iterate on that rapidly.

[emtiu]

If I read the code correctly, there's only one single call to the atomic_write function. Could it be easier to just eliminate that call completely, and implement the write directly with functions from os?

[mathstuf]

Not as a with statement at least. Making a context manager to handle exceptions and error handling logic keeps it tidy even with a single call site, IMO.

[mathstuf]

To be more precise, open-coding it would push the actual "meat" of the logic in by 2 more indentations and decorate it with a dozen or so lines of "safety handling" noise (at least as far as reviewing the call site logic is concerned).

[emtiu]

I see, thanks for the explanation!

[lucc]

I migrated the original tests from atomicwrites. Some are still broken, maybe we can fix them or we might disable them.

@untitaker is it ok for you if I copy your MIT licensed tests into this GPL project (thus publishing a GPL version of the changed code)? See b6cce2a.

[mschilli87]

@lucc

@untitaker is it ok for you if I copy your MIT licensed tests into this GPL project (thus publishing a GPL version of the changed code)? See b6cce2a.

AFAIK you can include MIT licensed code in GPL licensed project without the need to re-license (and therefore with out approval of / consulting with the author of) that piece of code. Of course you'd have to leave the original copyright note in place.

[lucc]

Thanks @mathstuf !

I removed the tests that I migrated. I will open a followup PR for that and wait for untitaker there.