Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Conversation

@calvincorreli
Copy link

I've changed the way error handling works so if you send multiple messages at once, we won't raise an exception just because one of those messages failed. You'd really want to be able to parse the response and deal with them indidivually.

Plus, when the error message ends with a colon, the error parsing returned empty code and messages.

Here's the error I was getting back:

ERR: 105, Invalid Destination Address To:
ERR: 105, Invalid Destination Address To:
ERR: 105, Invalid Destination Address To:

(many more like these)

//Lars

@lukeredpath
Copy link
Owner

Hi Lars

Thanks for this. Whilst I appreciate the pull request, these changes really need some tests before I can merge them.

Thanks
Luke

@calvincorreli
Copy link
Author

Yeah yeah yeah, always the tests ... ;)

Had a problem to solve, so just solved it.

I have several other things, I might have to add - concat and unicode being the first two that come to mind.

Will keep the thing about tests in mind :)

//Lars

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants