-
-
Notifications
You must be signed in to change notification settings - Fork 23
v1.12 #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…interfaces instead of structs. Games con now better define specific functionality
* Server: implemented the gauntlet generation for AoM and other minor changes * Server: finalized challenge mode in AoM - AotG * Server: minor simplifications * Server: finalized avatar stats store, fixes to persistent data store
* Server: Implement updating user profile data * Update README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> * Update server/internal/models/persistentJsonData.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> --------- Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Select argument), false by default (#326)
…LAN server increasing performance and fixing interoperability with AgeFakeHost.dll (#327)
#328) * Add support for windows 7/8.X, except for goreleaser and github action Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> --------- Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
#329) * Launcher: require isolation when using an official launcher. Moved Isolation from general to game config. Isolation values are now string and additionally support 'required' value * Update launcher/internal/cmd/root.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> * Update launcher/internal/cmd/root.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> * Update launcher/internal/cmd/root.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> * Update launcher/resources/config.game.toml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> * Update launcher/internal/cmd/root.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> --------- Signed-off-by: David Fernández Aldana <luskaner@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
#330) * Fix pidlock trying to kill process not belonging to us and also erroring out
#335) * Launcher: Check game CA if certificate needs adding like with the regular CA certificate
…338) * Replace os-specific debug commands with a go script and cache tasks
#340) * Launcher: use local viper instance, unmarshall to struct and set defaults
…s and fixed memory leaks (#341)
* Update go 1.24 to 1.25, libraries and documentation * fix to previous commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This is version 1.12 of the ageLANServer project, introducing significant architectural refactoring and new features for Age of Mythology (AoM) support, particularly around the Gauntlet game mode.
Key Changes:
- Major refactoring to use interfaces for core types (User, Session, Advertisement, etc.) enabling better extensibility
- New server-replay tool for replaying server communication logs for debugging and testing
- Persistent user data storage system with versioning and upgrade support
- Gauntlet/Challenge mode implementation with labyrinth generation and mission management
- Go version upgrade from 1.24.0 to 1.25.5
- Dependency updates (Cobra, DNS, etc.)
Reviewed changes
Copilot reviewed 199 out of 232 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/server-replay/* | New developer tool for replaying communication logs for debugging and regression testing |
| tools/scripts/* | New build scripts for managing server resources |
| server/internal/models/* | Extensive refactoring to use interfaces, add persistent data, avatar stats, and session management |
| server/internal/models/athens/* | AoM-specific implementations including Gauntlet mode, user data, and cloud script functions |
| server/internal/routes/* | Updated to use new interface-based models and improved request binding |
| server/go.mod | Go version and dependency updates |
| server/resources/responses/athens/playfab/* | New Gauntlet configuration files |
Comments suppressed due to low confidence (1)
tools/server-replay/go.mod:3
- The Go version 1.25.5 specified in this file does not exist as of the knowledge cutoff date (January 2025). The latest stable Go version available at that time would be 1.23.x or 1.24.x. Please verify this version exists or use an available version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 198 out of 229 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
server/internal/models/athens/routes/playfab/cloudScriptFunction/buildGauntletLabyrinth/generator.go:1
- This magic number array should be documented or converted to a constant with clear explanation of what each index represents in the blessing level system.
server/internal/routes/wss/wss.go:1 - Line 199 unnecessarily assigns nil to sess when it's already zero-valued. This line can be removed.
server/internal/models/athens/routes/playfab/cloudScriptFunction/awardMissionRewards.go:1 - Array access elements[1] without bounds checking could cause a panic if MissionId doesn't contain an underscore or has only one element. Add length validation before accessing array elements.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.