Skip to content

Conversation

Copy link

Copilot AI commented Aug 6, 2025

This patch removes function names from the beginning of all logging calls in the src/ipc directory as requested. The changes affect logging macros including comp_info(), comp_dbg(), comp_err(), comp_warn(), tr_info(), tr_dbg(), tr_err(), tr_warn(), and related variants.

Changes Made

  • 79 lines modified across 9 C files in the src/ipc directory
  • 79 function names removed from logging statements
  • Log levels, parameters, and formatting preserved
  • No functional logic changes, only string content modifications

Examples of Changes

Function names with messages:

// Before
tr_err(&ipc_tr, "ipc_process_on_core(): core #%d is disabled", core);
comp_err(dev, "dai_config(): No memory for dai_config size %d", size);

// After  
tr_err(&ipc_tr, "core #%d is disabled", core);
comp_err(dev, "No memory for dai_config size %d", size);

Standalone function name logging:

// Before
tr_dbg(&ipc_tr, "ipc_init()");

// After
tr_dbg(&ipc_tr, "");

Files Modified

  • src/ipc/dma-copy.c - 4 function names removed
  • src/ipc/ipc-common.c - 2 function names removed
  • src/ipc/ipc-helper.c - 6 function names removed
  • src/ipc/ipc4/helper.c - 4 function names removed
  • src/ipc/ipc4/dai.c - 8 function names removed
  • src/ipc/ipc3/helper.c - 19 function names removed
  • src/ipc/ipc3/host-page-table.c - 6 function names removed
  • src/ipc/ipc3/dai.c - 10 function names removed
  • src/ipc/ipc3/handler.c - 20 function names removed

All changes have been verified to ensure no logging patterns remain that include function names at the beginning of log messages. The patch maintains all existing log levels and preserves the informational content of the messages.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: lyakh <1363683+lyakh@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove function names from logging calls in src/ipc directory Remove function names from logging calls in src/ipc directory Aug 6, 2025
Copilot AI requested a review from lyakh August 6, 2025 06:49
assert_can_be_cold();

tr_dbg(&ipc_tr, "ipc_init()");
tr_dbg(&ipc_tr, "");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line comment makes no sense, for such cases let's put, say "function entry" there since usually that's where such calls show up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants