Fix stepCallback logic #74
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you for this nice library. There is a small bug, though, and I am surprised, no one did complain, yet.
Problem is, that if you type a long word, the calculated text size is too large. For example, if you enter
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
in the textarea on the example page, the text goes out of bounds.
Change is small, short explanation:
Let's say fontSize 10 is the correct result, and the loop get's to the situation that low is 10 and high is 11. mid is set to 10, testSecondary() returns true, so low is set to 11.
With the current code, the loop is complete and the chosen fontSize is 11.
With the change, there would be another loop call, mid is set to 11, testSecondary() returns false and high is set to 10, which would return the correct fontSize.