Skip to content

Conversation

@micha-lmxt
Copy link

Add typescript declaration file

@iofjuupasli
Copy link

Please add children type, and make props optional

@micha-lmxt
Copy link
Author

good points, it's updated

@ZekNikZ
Copy link

ZekNikZ commented Aug 8, 2021

import React from 'react';

interface Props {
    text?: string;
    min?: number;
    max?: number;
    mode?: 'single' | 'multi';
    forceSingleModeWidth?: boolean;
    throttle?: number;
    onReady?: (number) => void;
}

declare module 'react-textfit' {
    export declare class Textfit extends React.Component<Props> {}
    export default Textfit;
}

Would not this be better? Accounts for children and more explicitly describes the exports

@peterblazejewicz
Copy link

to be fixed in: DefinitelyTyped/DefinitelyTyped#58461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants