-
Notifications
You must be signed in to change notification settings - Fork 161
Chrome custom tabs #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Chrome custom tabs #175
Conversation
|
Thank you. I just released a fix for the comments parsing and will try to take a look at your PR by the end of the week. |
a8bbb2d to
581bf44
Compare
|
@0xKD This is great, but there is no way to switch between the article and the comments when using the Chrome Tabs. Unfortunately, I don't have much experience with Chrome Tabs for now. Do you know, if there is any way to customise the toolbar of the chrome tab (I will have to research this myself as well)? If there isn't, then we have to make it a setting and let the user choose, if they want to open the Articles, via a ChromeTab, Webview in the App or the system browser? Would you be interested in making this improvement in the SettingsActivity before we can merge this? Thanks! |
|
There is a way to switch to the article from the comments but not the other way round. This can be added using a custom action button, and is something I tried, but there is no clean way (or I couldn't figure out one) to go back to the list of posts (something that is currently done using |
|
Ok, I will try to have a look this weekend, if there is a way to customise the toolbar or how to add an action button. Any help and/or info is greatly appreciated. For now we could make it a setting and let people choose performance over ease of use. |
581bf44 to
8c2bacb
Compare
- This is a preference in Settings -> "View Articles within.." - Fallback to webview (if Chrome or equivalent browser not installed)
8c2bacb to
5e1dafa
Compare
|
I've made this a preference in the settings screen and added a button which takes you to the comments from the article (demo video) |
|
That looks awesome. Thank you very much! I'll try to merge and publish it today. |
Open links in Chrome custom tabs (if available), falling back to webview.