Skip to content

Conversation

@0xKD
Copy link

@0xKD 0xKD commented Aug 14, 2016

Open links in Chrome custom tabs (if available), falling back to webview.

@peshkira
Copy link
Collaborator

Thank you. I just released a fix for the comments parsing and will try to take a look at your PR by the end of the week.

@0xKD 0xKD force-pushed the chrome-custom-tabs branch 3 times, most recently from a8bbb2d to 581bf44 Compare August 20, 2016 12:58
@peshkira
Copy link
Collaborator

@0xKD This is great, but there is no way to switch between the article and the comments when using the Chrome Tabs. Unfortunately, I don't have much experience with Chrome Tabs for now. Do you know, if there is any way to customise the toolbar of the chrome tab (I will have to research this myself as well)?

If there isn't, then we have to make it a setting and let the user choose, if they want to open the Articles, via a ChromeTab, Webview in the App or the system browser?

Would you be interested in making this improvement in the SettingsActivity before we can merge this?

Thanks!

@0xKD
Copy link
Author

0xKD commented Aug 24, 2016

There is a way to switch to the article from the comments but not the other way round. This can be added using a custom action button, and is something I tried, but there is no clean way (or I couldn't figure out one) to go back to the list of posts (something that is currently done using finish(), instead of the article comments), when one goes from Comments -> Article and then hits the back button.

@peshkira
Copy link
Collaborator

Ok, I will try to have a look this weekend, if there is a way to customise the toolbar or how to add an action button. Any help and/or info is greatly appreciated.

For now we could make it a setting and let people choose performance over ease of use.

@0xKD 0xKD force-pushed the chrome-custom-tabs branch from 581bf44 to 8c2bacb Compare August 28, 2016 11:09
- This is a preference in Settings -> "View Articles within.."
- Fallback to webview (if Chrome or equivalent browser not installed)
@0xKD 0xKD force-pushed the chrome-custom-tabs branch from 8c2bacb to 5e1dafa Compare August 28, 2016 11:41
@0xKD
Copy link
Author

0xKD commented Aug 28, 2016

I've made this a preference in the settings screen and added a button which takes you to the comments from the article (demo video)

@peshkira
Copy link
Collaborator

That looks awesome. Thank you very much! I'll try to merge and publish it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants