Skip to content

Feat: Add ignorelist to streetView #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giovanniborella wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat: Add ignorelist to streetView #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
677be52
add ignorelist
giovanniborella Mar 31, 2025
ed02253
fix typo. calculate defaults
giovanniborella Apr 3, 2025
e43d5d3
dont check for length
giovanniborella Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,17 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [CalVer](https://calver.org/).

## [Unreleased]

### Added

- A new config `extensionConfig.streetView.ignorelist`. This setting will not render the buttons for selected options. possible values. (To hide `cowi` - no not set `extensionConfig.streetView.cowi`):
- google
- mapillary
- skraafoto
- maps


## [2025.3.2] - 2025-28-3

### Added
Expand Down
108 changes: 73 additions & 35 deletions extensions/streetView/browser/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ let mapObj;
let config = require('../../../config/config.js');

let cowiUrl = config?.extensionConfig?.streetView?.cowi;
let ignorelist = config?.extensionConfig?.streetView?.ignorelist || [];

// check if cowiUrl is set, if not, add it to the ignorelist
// This is a way to keep the old functionality of the extension, but also to allow for a new way of using the extension
if (!cowiUrl) {
ignorelist.push("cowi");
}

const availableServices = ["google", "mapillary", "skraafoto", "maps", "cowi"];
let mapillaryUrl = config?.extensionConfig?.streetView?.mapillary ||"https://www.mapillary.com/app/?z=17";

/**
Expand Down Expand Up @@ -143,9 +152,19 @@ module.exports = {
constructor(props) {
super(props);

// Find the first available service that is not in the ignorelist, Use this as default
let defaultService = "google"; // Fallback default
for (let service of availableServices) {
if (!ignorelist.includes(service)) {
defaultService = service;
break;
}
}

// Use config default if specified, otherwise use the computed default
this.state = {
active: false,
selectedOption: config?.extensionConfig?.streetView?.default || "google"
selectedOption: config?.extensionConfig?.streetView?.default || defaultService
};

this.onChange = this.onChange.bind(this);
Expand Down Expand Up @@ -242,42 +261,61 @@ module.exports = {
<div className="form-group">
<div className="d-flex flex-column gap-4">
<span className="btn-group">
<input className="btn-check" type="radio" id="streetview-service-google"
name="streetview-service"
value="google" checked={this.state.selectedOption === 'google'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-google">Street View</label>

<input className="btn-check" type="radio" id="streetview-service-mapillary"
name="streetview-service" value="mapillary"
checked={this.state.selectedOption === 'mapillary'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-mapillary">Mapillary</label>

<input className="btn-check" type="radio" id="streetview-service-skraafoto"
name="streetview-service" value="skraafoto"
checked={this.state.selectedOption === 'skraafoto'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-skraafoto">Skråfoto</label>
<input className="btn-check" type="radio" id="streetview-service-maps"
name="streetview-service" value="maps"
checked={this.state.selectedOption === 'maps'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-maps">Maps</label>
{cowiUrl !== undefined ?
{!ignorelist.includes("google") ?
<>
<input className="btn-check" type="radio" id="streetview-service-google"
name="streetview-service"
value="google" checked={this.state.selectedOption === 'google'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-google">StreetView</label>
</>
: null
}
{!ignorelist.includes("mapillary") ?
<>
<input className="btn-check" type="radio" id="streetview-service-mapillary"
name="streetview-service"
value="mapillary" checked={this.state.selectedOption === 'mapillary'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-mapillary">Mapillary</label>
</>
: null
}
{!ignorelist.includes("skraafoto") ?
<>
<input className="btn-check" type="radio" id="streetview-service-skraafoto"
name="streetview-service"
value="skraafoto" checked={this.state.selectedOption === 'skraafoto'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-skraafoto">Skråfoto</label>
</>
: null
}
{!ignorelist.includes("maps") ?
<>
<input className="btn-check" type="radio" id="streetview-service-maps"
name="streetview-service"
value="maps" checked={this.state.selectedOption === 'maps'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-maps">Maps</label>
</>
: null
}
{!ignorelist.includes("cowi") ?
<>
<input className="btn-check" type="radio" id="streetview-service-cowi"
name="streetview-service" value="cowi"
checked={this.state.selectedOption === 'cowi'}
onChange={this.onChange}/> : null
}
{cowiUrl !== undefined ?
name="streetview-service"
value="cowi" checked={this.state.selectedOption === 'cowi'}
onChange={this.onChange}/>
<label className="btn btn-sm btn-outline-secondary"
htmlFor="streetview-service-cowi">COWI Gadefoto</label> : null
}
htmlFor="streetview-service-cowi">COWI Gadefoto</label>
</>
: null
}
</span>
</div>
</div>
Expand Down