-
Notifications
You must be signed in to change notification settings - Fork 25
Feat: Add Prometheus metrics #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
giovanniborella
wants to merge
24
commits into
mapcentia:master
Choose a base branch
from
giovanniborella:metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trollers, and Express server
Normalize /api/symbols/ in metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces Prometheus metrics to the project, enabling detailed monitoring of various operations. Metrics are added for SQL queries, WMS requests, print operations, and HTTP endpoints, allowing tracking of counts, durations, and response sizes. Additionally, documentation has been updated to reflect these changes and provide configuration instructions.
The feature has been implemented as an "Opt-in", and the metrics are not yet feature-complete - more metrics may be added down the line.
There is no dashboard yet, but one is in the works.
Metrics Implementation:
SQL Controller (
controllers/gc2/sql.js):db,format, andstatus. [1] [2]WMS Controller (
controllers/gc2/wms.js):db,request_type, andstatus. [1] [2]Print Controller (
controllers/print.js):scale,format,template, anddb. Metrics are updated for success, error, and various formats (e.g., PNG, PDF). [1] [2] [3] [4] [5]Documentation Updates:
docs/pages/standard/90_build_configuration.rstwith instructions for enabling metrics in theconfig.jsfile, including endpoint and port configuration for Prometheus integration.Changelog:
CHANGELOG.mdsummarizing the new Prometheus metrics feature, including details on supported controllers and metrics types.