Update framework to ignore most formatting differences between #542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache JDBC and Simba JDBC results. Added ability to include Jira number to failed tests.
kkhatua
reviewed
Mar 14, 2019
| StringBuilder sb = new StringBuilder(); | ||
| for (int i = 0; i < values.size() - 1; i++) { | ||
| int type = (Integer) (types.get(i)); | ||
| if (Simba && (type == Types.VARCHAR)) { |
Contributor
There was a problem hiding this comment.
This should ideally be set as isSimba
| if ((s1.length() > 0) && | ||
| ((s1.charAt(0) == '{') || (s1.charAt(0) == '[')) ) { | ||
| s1 = Utils.removeNewLines(s1); | ||
| s1 = removeStringSpace(s1); |
Contributor
There was a problem hiding this comment.
There might be libraries that do the reverse of prettifying JSON string, including stripping down extra spaces. Consider having a single Util method that does something like s1 = Utils.compactJson(s1);
| if (FOUNDFAILED) { | ||
| return null; | ||
| } else { | ||
| return Filename; |
Contributor
There was a problem hiding this comment.
Variables need to be in lower camel case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache JDBC and Simba JDBC results.
Added ability to include Jira number to failed tests.