Skip to content

fix: Ensure infinite scroll properly loads more climb results #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcodejongh wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: Ensure infinite scroll properly loads more climb results #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/web/app/components/queue-control/hooks/use-queue-data-fetching.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const useQueueDataFetching = ({
initialSize: searchParams.page ? searchParams.page + 1 : 1,
});

const hasMoreResults = data && data[0] && size * PAGE_LIMIT < data[0].totalCount;
const hasMoreResults = Boolean(data && data[0] && size * PAGE_LIMIT < data[0].totalCount);
const totalSearchResultCount = (data && data[0] && data[0].totalCount) || null;

const climbSearchResults = useMemo(
Expand Down Expand Up @@ -102,7 +102,7 @@ export const useQueueDataFetching = ({
}, [climbSearchResults, hasDoneFirstFetch, setHasDoneFirstFetch]);

const fetchMoreClimbs = useCallback(() => {
setSize((oldSize) => {
return setSize((oldSize) => {
const newParams = { ...searchParams, page: oldSize + 1 };
history.replaceState(null, '', `${window.location.pathname}?${searchParamsToUrlParams(newParams).toString()}`);
return oldSize + 1;
Expand Down
2 changes: 1 addition & 1 deletion packages/web/app/components/queue-control/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export interface QueueContextType {
setCurrentClimbQueueItem: (item: ClimbQueueItem) => void;
setClimbSearchParams: (params: SearchRequestPagination) => void;
mirrorClimb: () => void;
fetchMoreClimbs: () => void;
fetchMoreClimbs: () => Promise<unknown>;
getNextClimbQueueItem: () => ClimbQueueItem | null;
getPreviousClimbQueueItem: () => ClimbQueueItem | null;
setQueue: (queue: ClimbQueueItem[]) => void;
Expand Down