Skip to content

fix: Always enable party mode button with helpful configuration message #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcodejongh wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −1
Open

fix: Always enable party mode button with helpful configuration message #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/web/app/components/board-page/share-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export const ShareBoardButton = () => {
type="default"
onClick={showDrawer}
icon={!isConnected && isConnecting ? <LoadingOutlined /> : <TeamOutlined />}
disabled={!isBackendMode && !clientId}
/>
</Badge>
<Drawer
Expand Down Expand Up @@ -122,6 +121,29 @@ export const ShareBoardButton = () => {
{/* Backend Mode Content */}
{!isControllerMode && (
<>
{/* No backend configured */}
{!isBackendMode && (
<Flex
vertical
align="center"
gap="middle"
style={{
padding: '24px',
background: themeTokens.colors.warningBg,
border: `1px solid ${themeTokens.colors.warning}`,
borderRadius: themeTokens.borderRadius.md,
}}
>
<Text strong style={{ color: themeTokens.colors.warning }}>
Party Mode Not Configured
</Text>
<Text type="secondary" style={{ textAlign: 'center' }}>
Set the NEXT_PUBLIC_WS_URL environment variable to your backend WebSocket URL and redeploy to
enable Party Mode.
</Text>
</Flex>
)}

{/* Connecting */}
{isConnecting && (
<Flex vertical align="center" gap="middle" style={{ padding: '24px' }}>
Expand Down