Fix ClearSign UTF-8 encoding corruption #321
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



The
ClearSignmethods were using ASCII encoding to convert text to bytes, corrupting non-ASCII characters (š → ?, € → ?, 中文 → ???).Changes
OutputClearSignedandOutputClearSignedAsync: ChangedEncoding.ASCII.GetBytes()toEncoding.UTF8.GetBytes()for line content conversionExample
The change affects only the encoding step in clear-signing; signature generation and verification remain unchanged.
Testing
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.