Fix file transfer issue #64
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Summary
This pull request fixes issue #56 by implementing missing functionality and resolving compatibility issues in the Tailscale Status GNOME extension.
Detailed Changes
1. Added Missing
cmdTailscaleFileFunction (Lines 430-458)2. Fixed Variable Declaration Bug (Line 460)
args = ["switch", "--list"](missingletdeclaration)let args = ["switch", "--list"](proper variable declaration)3. Changed Logging Functions (Lines 89, 93)
console.log("🟡 [tailscale-status]: " + string);log("🟡 [tailscale-status]: " + string);console.log("🔴 [tailscale-status]: " + string);log("🔴 [tailscale-status]: " + string);4. Updated Constructor Signature (Line 619)
_init(dir_path) {_init() {5. Updated Icon Path References (Lines 622-624)
icon_down = Gio.icon_new_for_string(dir_path + '/icon-down.svg');icon_down = Gio.icon_new_for_string(Me.dir.get_path() + '/icon-down.svg');icon_up = Gio.icon_new_for_string(dir_path + '/icon-up.svg');icon_up = Gio.icon_new_for_string(Me.dir.get_path() + '/icon-up.svg');icon_exit_node = Gio.icon_new_for_string(dir_path + '/icon-exit-node.svg');icon_exit_node = Gio.icon_new_for_string(Me.dir.get_path() + '/icon-exit-node.svg');6. Updated TailscalePopup Instantiation (Line 806)
tailscale = new TailscalePopup(this.path);tailscale = new TailscalePopup();7. Updated Settings Access (Line 802)
SETTINGS = this.getSettings('org.gnome.shell.extensions.tailscale-status');SETTINGS = ExtensionUtils.getSettings('org.gnome.shell.extensions.tailscale-status');8. Simplified Disable Function (Lines 810-822)
9. Added Function Structure Changes
init(),enable(), anddisable()functionsImpact
These changes resolve issue #56 by:
cmdTailscaleFilefunction that was referenced but not definedconsole.logtologfor better GNOME shell integrationThe extension should now function properly without runtime errors and missing function implementations.
Testing
This fix was tested today on Linux Debian 12 by successfully sending files to a Samsung Galaxy S22+ device using the Tailscale file transfer functionality.