feat: add a nicer site menu #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive navigation menu redesign with a new topic-based content organization system. The changes enhance site navigation by adding curated topic clusters, implementing modern UI components from Radix UI, and improving the overall user experience with dropdown menus and better mobile navigation.
Key Changes:
- New topic pages system that aggregates content by tags into themed collections (React Development, Startup Building, Design & UX, Developer Productivity)
- Modern dropdown navigation menu using Radix UI components with improved desktop and mobile experiences
- Performance optimizations including image optimization, font display swap, and disabled production source maps
Reviewed changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/lib/topics.ts |
New library for topic management with content aggregation logic |
src/pages/topics/index.tsx |
Topic landing page displaying all topic clusters |
src/pages/topics/[slug].tsx |
Individual topic page with filtered content listings |
src/utils/generateStructuredData.tsx |
Added CollectionPage schema for topic SEO |
src/components/Navbar/Navbar.tsx |
Redesigned navigation with dropdown menus for Topics and Browse sections |
src/components/ui/tooltip.tsx |
New Radix UI tooltip component |
src/components/ui/navigation-menu.tsx |
New Radix UI navigation menu component |
src/styles/globals.css |
Added theme variables and custom variant for dark mode support |
src/components/soldOut.tsx |
Refactored from styled-jsx to Tailwind CSS utilities |
src/components/Image/Image.tsx |
Added sizes prop and aspect ratio styling for better image optimization |
src/components/Headshot/Headshot.tsx |
Changed from unoptimized to quality prop for image optimization |
src/components/ExternalWork/ExternalWorkItem.tsx |
Simplified component removing MDX rendering |
src/pages/_app.tsx |
Added font-display swap for better performance |
src/pages/index.tsx |
Added priority prop to headshot image |
src/app/sitemap.ts |
Added topic pages to sitemap generation |
next.config.mjs |
Disabled production browser source maps |
components.json |
Added shadcn/ui configuration |
package.json |
Added Radix UI navigation and tooltip dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.