dbf fields stop at char 00 #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fil this looks like a reasonable fix, why did you close the PR? |
Author
|
I didn't intend to close it, but cleaned up my personal repos and didn't realize this fork was home to a PR. Thanks for noticing! |
|
I've seen Shapefile dbfs like this in circulation, too... hope @mbostock will consider merging. |
mbostock
approved these changes
Feb 16, 2023
Comment on lines
+20
to
+21
| var v = value.subarray(i, i += f.length); | ||
| var j = v.indexOf(0); |
Owner
There was a problem hiding this comment.
Suggested change
| var v = value.subarray(i, i += f.length); | |
| var j = v.indexOf(0); | |
| var v = value.subarray(i, i += f.length), j = v.indexOf(0); |
|
@mbostock any chance of releasing this? It fixes an issue I'm hitting currently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #68 #70