Buffered run script option #79
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckendrick
force-pushed
the
runscript_buffered
branch
from
3230a92 to
679267a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
use_bufferoption torun_script.runwhich changes the way an instrument script is compiled. The buffered version launches each componentprocesskernel separately rather than one kernel for each component'spropagate.This is mainly to help explore different options (refer to #77) for running the instrument to help performance with components like the tapered guide. With this buffered approach, each component can have a different kernel launch configuration, which may help occupancy for particular components or allow for filtering of absorbed neutrons between components.