Skip to content

[WC-3203] Gallery: Enable row count display on virtual scroll #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yordan-st wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WC-3203] Gallery: Enable row count display on virtual scroll #2009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/gallery-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- We fixed an issue where the row count wasn't displayed when "Virtual scroll" is on.

### Added

- We added a refresh interval property, to allow defining an interval (in seconds) for refreshing the content in Gallery
Expand Down
4 changes: 0 additions & 4 deletions packages/pluggableWidgets/gallery-web/src/Gallery.editorConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ export function getProperties(values: GalleryPreviewProps, defaultProperties: Pr
hidePropertyIn(defaultProperties, values, "onConfigurationChange");
}

// Hide scrolling settings for now.
hidePropertiesIn(defaultProperties, values, ["showPagingButtons", "showTotalCount"]);
/** Pagination */

if (values.pagination === "buttons") {
hidePropertyIn(defaultProperties, values, "showTotalCount");
} else {
Expand Down
Loading