Skip to content

Do not render the vertical time line in case there are no time line elements. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BartReyserhove wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not render the vertical time line in case there are no time line elements. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 40 additions & 29 deletions Gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,42 +33,53 @@ const clean = () => {
const replaceStandalone = () => replace(' (standalone)', '');

const copyWebModelerFiles = () =>
gulp.src([
path.join(tmpContainerFolder, `${fileNameContainer}.webmodeler.js`),
path.join(tmpElementFolder, `${fileNameElement}.webmodeler.js`)
]).pipe(gulp.dest(tmpFolder)).on("error", console.error);

const copyContainerXML = () =>
gulp.src(
path.join(tmpContainerFolder, `${fileNameContainer}.xml`)
).pipe(replaceStandalone()).pipe(
replace('mendix.timelinecontainer.TimelineContainer', `mendix.${mainPKGName}.TimelineContainer`)
).pipe(gulp.dest(tmpFolder)).on("error", console.error);

const copyElementXML = () =>
gulp.src(
path.join(tmpElementFolder, `${fileNameElement}.xml`)
).pipe(replaceStandalone()).pipe(
replace('mendix.timelineelement.TimelineElement', `mendix.${mainPKGName}.TimelineElement`)
).pipe(gulp.dest(tmpFolder)).on("error", console.error);

const copyContainerCSSFiles = () =>
gulp.src([
path.join(tmpContainerFolder, `mendix/timelinecontainer/ui/${fileNameContainer}.css`),
// path.join(tmpContainerFolder, `mendix/timelinecontainer/ui/${fileNameContainer}.css.map`),
]).pipe(gulp.dest(path.join(dstFolder, "ui"))).on("error", console.error);

const copyWidgetFiles = () =>
gulp.src([
{
return gulp.src([
path.join(tmpContainerFolder, `${fileNameContainer}.webmodeler.js`),
path.join(tmpElementFolder, `${fileNameElement}.webmodeler.js`)
]).pipe(gulp.dest(tmpFolder)).on("error", console.error);
}


const copyContainerXML = () => {
return gulp.src(
path.join(tmpContainerFolder, `${fileNameContainer}.xml`)
).pipe(replaceStandalone()).pipe(
replace('mendix.timelinecontainer.TimelineContainer', `mendix.${mainPKGName}.TimelineContainer`)
).pipe(gulp.dest(tmpFolder)).on("error", console.error);
}

const copyElementXML = () => {
return gulp.src(
path.join(tmpElementFolder, `${fileNameElement}.xml`)
).pipe(replaceStandalone()).pipe(
replace('mendix.timelineelement.TimelineElement', `mendix.${mainPKGName}.TimelineElement`)
).pipe(gulp.dest(tmpFolder)).on("error", console.error);
}

const copyContainerCSSFiles = () => {
return gulp.src([
path.join(tmpContainerFolder, `mendix/timelinecontainer/ui/${fileNameContainer}.css`),
// path.join(tmpContainerFolder, `mendix/timelinecontainer/ui/${fileNameContainer}.css.map`),
]).pipe(gulp.dest(path.join(dstFolder, "ui"))).on("error", console.error);
}


const copyWidgetFiles = () => {
return gulp.src([
path.join(tmpContainerFolder, `mendix/timelinecontainer/${fileNameContainer}.js`),
path.join(tmpElementFolder, `mendix/timelineelement/${fileNameElement}.js`),
]).pipe(gulp.dest(dstFolder)).on("error", console.error);
}


const copyPackageXML = () =>
gulp
const copyPackageXML = () => {
return gulp
.src(path.join(__dirname, "package.xml"))
.pipe(replace("XXX", pkg.version))
.pipe(gulp.dest(tmpFolder)).on("error", console.error);
}


const zipPackage = () =>
gulp.
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions widgets/container/src/TimelineContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ class TimelineContainer extends Component<TimelineContainerContainerProps> {
return null;
}

if (dataSource.items && dataSource.items.length === 0) {
return null;
}

return (
<VerticalTimeline
className={this.props.class}
Expand Down