Skip to content

test if contiguity error is resolved by avoiding contiguous() #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Dan-Flores wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test if contiguity error is resolved by avoiding contiguous() #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/torchcodec/_core/CudaDeviceInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,14 +417,24 @@ UniqueAVFrame CudaDeviceInterface::convertCUDATensorToAVFrameForEncoding(
avFrame != nullptr && avFrame->data[0] != nullptr,
"avFrame must be pre-allocated with CUDA memory");

// TODO VideoEncoder: Investigate ways to avoid this copy
torch::Tensor hwcFrame = tensor.permute({1, 2, 0}).contiguous();
const Npp8u* pSrc[3] = {
static_cast<const Npp8u*>(tensor.data_ptr()) +
0 * tensor.stride(0) * tensor.element_size(), // R plane
static_cast<const Npp8u*>(tensor.data_ptr()) +
1 * tensor.stride(0) * tensor.element_size(), // G plane
static_cast<const Npp8u*>(tensor.data_ptr()) +
2 * tensor.stride(0) * tensor.element_size() // B plane
};

int aSrcStep[3] = {
static_cast<int>(tensor.stride(1) * tensor.element_size()),
static_cast<int>(tensor.stride(1) * tensor.element_size()),
static_cast<int>(tensor.stride(1) * tensor.element_size())};

NppiSize oSizeROI = {width, height};
NppStatus status = nppiRGBToNV12_8u_ColorTwist32f_C3P2R_Ctx(
static_cast<const Npp8u*>(hwcFrame.data_ptr()),
validateInt64ToInt(
hwcFrame.stride(0) * hwcFrame.element_size(), "nSrcStep"),
NppStatus status = nppiRGBToNV12_8u_ColorTwist32f_P3P2R_Ctx(
pSrc,
aSrcStep,
avFrame->data,
avFrame->linesize,
oSizeROI,
Expand Down
Loading