Skip to content

Conversation

@ferringb
Copy link

@ferringb ferringb commented Nov 11, 2025

So... I wasn't much willing to reconfigure my IDE to not reformat, so the first commit is a ruff reformat of the repo.

There are two main commits here:

  • make this debuggable via CLI. Specifically argument passing rather than stdin consumption, which in turn allows pdb.set_trace(). I also flipped on pretty print for any json dumping.
  • the fixes in question. The commit message for that is below.

Specifically, that's this:

    Fix exception for deletion events and force validation.
    
    Fixes
    * added boolean deleted and created fields per v3 spec.  These indicate
      if it's a ref deletion, new ref created, etc.
    
    * fixed the exception for deletion events
    
    * forced data annotation via dataclass, thus documenting the event structure.
      I did this explicitly because there are no tests and I had to rework a lot
      of this, so might as well use a dataclass to ensure I didn't drop any event
      data.  This is not runtime enforcement however.
    
    * fixed the comparison urls sent for a ref creation event.
    
    This is larger than intended, but the data validation I had to shove in to
    verify I didn't break anything.  The result is simpler/cleaner however.

Signed-off-by: Brian Harring <ferringb@gmail.com>
Signed-off-by: Brian Harring <ferringb@gmail.com>
Signed-off-by: Brian Harring <ferringb@gmail.com>
Fixes
* added boolean deleted and created fields per v3 spec.  These indicate
  if it's a ref deletion, new ref created, etc.

* fixed the exception for deletion events

* forced data annotation via dataclass, thus documenting the event structure.
  I did this explicitly because there are no tests and I had to rework a lot
  of this, so might as well use a dataclass to ensure I didn't drop any event
  data.  This is not runtime enforcement however.

* fixed the comparison urls sent for a ref creation event.

This is larger than intended, but the data validation I had to shove in to
verify I didn't break anything.  The result is simpler/cleaner however.

Signed-off-by: Brian Harring <ferringb@gmail.com>
@ferringb
Copy link
Author

The above is shook out as much as I can do so, including with the followon PR's flexing it in different ways. please take a look.

ferringb added a commit to ferringb/notify-webhook that referenced this pull request Nov 11, 2025
Note: this actually fails on the first commit in history;
diff-tree is against the parent.  It's edge case, but it exists.

This is a seperated PR from metajack#29 for review reasons.  When this and that
lands, issue metajack#28 can be closed.

Signed-off-by: Brian Harring <ferringb@gmail.com>
ferringb added a commit to ferringb/notify-webhook that referenced this pull request Nov 12, 2025
Note: this actually fails on the first commit in history;
diff-tree is against the parent.  It's edge case, but it exists.

This is a seperated PR from metajack#29 for review reasons.  When this and that
lands, issue metajack#28 can be closed.

Signed-off-by: Brian Harring <ferringb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant