Skip to content

feat(metrics): Make noop() constructors const fn #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alex wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

feat(metrics): Make noop() constructors const fn #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions metrics/src/handles.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ impl Counter {
///
/// Suitable when a handle must be provided that does nothing i.e. a no-op recorder or a layer
/// that disables specific metrics, and so on.
pub fn noop() -> Self {
pub const fn noop() -> Self {
Self { inner: None }
}

Expand Down Expand Up @@ -118,7 +118,7 @@ impl Gauge {
///
/// Suitable when a handle must be provided that does nothing i.e. a no-op recorder or a layer
/// that disables specific metrics, and so on.
pub fn noop() -> Self {
pub const fn noop() -> Self {
Self { inner: None }
}

Expand Down Expand Up @@ -154,7 +154,7 @@ impl Histogram {
///
/// Suitable when a handle must be provided that does nothing i.e. a no-op recorder or a layer
/// that disables specific metrics, and so on.
pub fn noop() -> Self {
pub const fn noop() -> Self {
Self { inner: None }
}

Expand Down